CI: add integration tests with python 3.13 #336
Conversation
fruch
force-pushed
the
int_tests_on_3.13
branch
2 times, most recently
from
1ec3337
to
6926e6b
Compare
|
7 failing tests, cause we move to test scylla 5.4: if we'll move to scylla 6.0, it would be worse. the driver matrix should have helped knowing about those, but matrix isn't running cqlengine tests... we introduced it here in the repo. |
|
FYI |
Thanks, we should mark it in the code to be skipped somehow cqlengine issues, I hate it, but we have customers using that, and we need to attend to it somehow. |
|
I've found that 2 of the test are XPASS, and we are in strict mode, hence this is failing. seems like those two now works from version 5.2 and up |
since we want to start test the alpha/beta version of python refactoring a bit the integration test workflow the action for pyenv we are using isn't really getting updates too much, and trying to switch back to the offical use python action that can now have prerelease python versions
so far the code assumed view can be name like:
```python
possible_names = [name, f'values({name})']
```
we have now one more option, that need to be considered:
```python
f'keys({name})'
```
|
I've handle all the issue beside
|
some test that was marked with @xfail_scylla, are now passing with newer release, i.e. some issue were fixed. so this new decorator can xfail up to a certion scylla_version note that it support both a oss version, and enterprise version
at some point scylla started validation of the arguments to compaction and newer versions rejects the values passed from this test chnaged it to something within the values expected
test is failing with the following: ``` cassandra.InvalidRequest: Error from server: code=2200 [Invalid query] message="Order by currently only supports the ordering of columns following their declared order in the PRIMARY KEY" ``` seems like scylla doesn't support ordering by clustering keys Ref: scylladb#343
|
@Lorak-mmk care to give it a look The only failure we have here is one integration run being stuck We have here changes that moves us to using scylla 5.4 |
| @@ -390,6 +390,17 @@ def _id_and_mark(f): | |||
| requires_custom_payload = pytest.mark.skipif(SCYLLA_VERSION is not None or PROTOCOL_VERSION < 4, | |||
| reason='Scylla does not support custom payloads. Cassandra requires native protocol v4.0+') | |||
| xfail_scylla = lambda reason, *args, **kwargs: pytest.mark.xfail(SCYLLA_VERSION is not None, reason=reason, *args, **kwargs) | |||
|
|
|||
|
|
|||
| def xfail_scylla_version(reason, oss_scylla_version, ent_scylla_version, *args, **kwargs): | |||
There was a problem hiding this comment.
Maybe xfail_scylla_version_less_than? Current name doesn't properly convey the meaning.
There was a problem hiding this comment.
Yeah, I thought maybe to support both options somehow, but I didn't had time todo so.
There was a problem hiding this comment.
I think of putting the version into pytest_markeval_namespace so can use pytest.mark.xfail directly
|
@dkropachev I didn't yet read your new PR ( #363 ). Is there something that this PR does that yours doesn't? If not, can this be closed as succeeded by #363 > |
|
Closed in favor of #363 |
since we want to start test the alpha/beta version of python refactoring a bit the integration test workflow
the action for pyenv we are using isn't really getting updates too much, and trying to switch back to the offical use python action that can now have prerelease python versions
also move to test newer scylla version which are not depended on python2 anymore, which was the main reason for using pyenv